2019-05-23 Brunel v54r2

This version uses Rec v23r5p1, Lbcom v22r1p1, LHCb v44r6, Gaudi v29r5 and LCG_93 with ROOT 6.12.06

This version is released on 2018-patches branch. It is intended for 2018 (Reco18) reconstruction in 2018 simulation workflows. Builds with gcc62 on slc6 and centos7 and with gcc7 on centos7

Built relative to Brunel v54r1, with the following changes:

New features

• Add Gitlab-CI job to check copyright, !696 (@clemenci)

• Add copyright, !695 (@cattanem)

• Propagate XGBoost-based IsPhoton separation variable to (Neutral)ProtoParticle::additionalInfo, Rec!1105, !430 (@deschamp)

• New pi0 gamma separation tool, LHCb!1348, Rec!1087 (@vchekali)
  Add Calo/CaloTools/GammaPi0XGBoostTool.h, GammaPi0XGBoostTool.cpp, XGBClassifierPhPi0.h, XGBClassifierPhPi0.cpp, CaloHypoEstimator.h, CaloHypoEstimator.cpp files to provide gamma-pi0 separation tools

• Add OT t0 time to protoparticle extrainfo, LHCb!1718, Rec!1392, !638 (@jadevrie)

Enhancements

• Update default LHCbCond tag for 2018, !1656 (@cattanem)
  Updated to cond-20181204-1, lhcb-conddb/LHCBCOND!29 (Reduce lumi thresholds to minimum for 2018 heavy ions)

Bug fixes

• Protect from division by zero in PrCounter2, Rec!1090 (@sstahl)

• Use L0Conf instead of DecodersDB to set up decoding of L0Report, Rec!1184 (@cattanem)

• Modify LHCb::ParticleID to solve the problems introduced by LHCb!1223, LHCb!1367 (@ibelyaev) [LHCBPS-1796]

• Fix issue with LHCbApp().OutputLevel, LHCb!1907, !774 (@cattanem)
  Fixes issue in which EventLoopMgr is wrongly configured when LHCbApp().OutputLevel is set.

• Properly suppress errors from Brunel during cache generation, !767 (@cattanem)

• Fix 2008-TED-Data options, !553 (@cattanem)

  • None of the decoding options in 2008-TED-Data.py were being taken into account because they are over-ridden by the settings in DecodersDB. Fixed by using a PostConfigAction
  • 2008-TED-Data.py was setting properties on DecodeVeloClusters, CreateTTClusters and CreateTTLiteClusters, but the actual names of the algorithms are createBothVeloClusters createTTClusters and createTTLiteClusters.
  • The RawEventLocations for TT were wrong for the particular data file used in the test

• Update 2018 test reference to follow InitialTime change in lhcb/LHCb!1220, !480 (@cattanem)

Code modernisations and cleanups

• Remove empty L0LinksSeq, !737 (@cattanem)

• Remove obsolete exclusions from BrunelExclusions.py, !707, !649 (@cattanem)

• Remove obsolete CVS keywords, !682 (@cattanem)

• Remove packages list from BrunelSys/CMakeLists.txt, !567 (@cattanem)
  Packages list was needed for SVN, no longer necessary with Git

• Remove unnecessary Hlt and L0 decoding sequences, !487, !488, !501 (@cattanem)

Changes to tests

• Hide eoslhcb SE directories from test comparisons, LHCb!1353 (@cattanem)

• Add symlink for reference of repro2012magdown test, c.f. !633, !639 (@cattanem)

• Set an InitialTime for 2018magup test and update ref to follow !487, !513 (@cattanem)

• Add test running over 2017 passthrough data, !485 (@rmatev)

• Add 2017 and 2018 database compatibility tests, !454 (@cattanem)
  Includes also:

  • fe68267f Remove InitialTime from 2016 database compatibility tests

• Update 2018 test to use a 2018 magdown RAW file, !446 (@cattanem)

• Add a Sim09 test, !426 (@cattanem) [LHCBGAUSS-1414]

  • Check any regressions in Brunel reconstruction of Sim09 2016 simulation
  • Second event checks regression of https://its.cern.ch/jira/browse/[LHCBGAUSS-1414](https://its.cern.ch/jira/browse/LHCBGAUSS-1414)

• Remove 2016magup-oldrich and 2016magup-vectorfit tests which are obsolete on this branch, !653 (@cattanem)

• Remove upgrade tests, not relevant on this branch, !413 (@cattanem)

• Update 2009 tests following inclusion of local tags into new global tag, !403 (@cattanem)